Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to customize the listener ports inside the container. #55

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

spetrovic77
Copy link
Contributor

This may be useful for local runs (e.g., minikube), where these ports can be made accessible directly to the host machine. In some ways, the port specification is equivalent to the "address" specification for the local deployers.

Also, add all exposed ports to the container spec, for better visibility.

This may be useful for local runs (e.g., minikube), where these ports can
be made accessible directly from the host machine. In some ways, the
port specification is equivalent to the "address" specification for
the local deployers.
Copy link
Member

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@spetrovic77 spetrovic77 merged commit 61a15f3 into main Sep 14, 2023
10 checks passed
@spetrovic77 spetrovic77 deleted the ports branch September 14, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants