Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes to support the Ardan Labs workflow. #52

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Small changes to support the Ardan Labs workflow. #52

merged 1 commit into from
Sep 11, 2023

Conversation

spetrovic77
Copy link
Contributor

Namely:

  • Allow the container to be built locally, but not pushed to a (remote) repository. The workshop application pushes the container image to the minikube-like cluster via a separate command, which doesn't require hosting the container in a repo.
  • Allow the container local build tag to be specified. The workshop application pushes the container image manually, so it is convenient to be able to specify a fixed tag the container is generated with.
  • Output the generated manifest file path when running weaver-gke deploy, so that scripts can pass that output to kubectl apply.
  • Place the manifest files into a temporary directory, as opposed to the current directory. This prevents files being created in the user's application directory, which is likely version controller.

@spetrovic77 spetrovic77 self-assigned this Sep 11, 2023
rgrandl
rgrandl approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@rgrandl rgrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

cmd/weaver-kube/deploy.go Outdated Show resolved Hide resolved
internal/impl/docker.go Show resolved Hide resolved
internal/impl/kube.go Outdated Show resolved Hide resolved
internal/impl/kube.go Show resolved Hide resolved
@spetrovic77
Small changes to support the Ardan Labs workflow.
2d54f8d 
Namely:
  * Allow the container to be built locally, but not pushed to
    a (remote) repository. The workshop application pushes the
    container image to the minikube-like cluster via a separate
    command, which doesn't require hosting the container in a repo.
  * Allow the container local build tag to be specified. The workshop
    application pushes the container image manually, so it is convenient
    to be able to specify a fixed tag the container is generated with.
  * Output the generated manifest file path when running weaver-gke deploy,
    so that scripts can pass that output to `kubectl apply`.
  * Place the manifest files into a temporary directory, as opposed to
    the current directory. This prevents files being created in the
    user's application directory, which is likely version controller.
@spetrovic77
Copy link
Contributor Author

Looks great!

Thank you!

@spetrovic77 spetrovic77 merged commit 90f88f9 into main Sep 11, 2023
10 checks passed
@spetrovic77 spetrovic77 deleted the ardan branch September 11, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrandl rgrandl rgrandl approved these changes

Assignees

@spetrovic77 spetrovic77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spetrovic77 @rgrandl