Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a container to a minikube registry, instead of GitHub registry. #51

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

spetrovic77
Copy link
Contributor

This solves the permissions issues when running integratino tests from non-ServiceWeaver org repositories (i.e., by external users).

Copy link
Member

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for figuring this out, Srdjan!

.github/workflows/integration.yml Outdated Show resolved Hide resolved
@spetrovic77
Copy link
Contributor Author

Nice! Thanks for figuring this out, Srdjan!

Thanks for suggesting we do this.

This solves the permissions issues when running integratino tests
from non-ServiceWeaver org repositories (i.e., by external users).
@spetrovic77 spetrovic77 merged commit 5f43b03 into main Aug 25, 2023
10 checks passed
@spetrovic77 spetrovic77 deleted the int2 branch August 25, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants