Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support to create app in any namespace #43

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

rgrandl
Copy link
Collaborator

@rgrandl rgrandl commented Aug 7, 2023

Before this PR, the Kube deployer was able to deploy an app only in the default namespace. With this PR, the user can deploy an app in any namespace. The custom namespace can be specified through config.

@rgrandl rgrandl force-pushed the deploy_custom_namespace branch 3 times, most recently from 156905c to 1f136db Compare August 7, 2023 00:17
Before this PR, the Kube deployer was able to deploy an app only in the
default namespace. With this PR, the user can deploy an app in any
namespace. The custom namespace can be specified through config.
Copy link
Contributor

@spetrovic77 spetrovic77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

internal/impl/kube.go Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@rgrandl rgrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Srdjan

@rgrandl rgrandl merged commit e2c2239 into main Aug 7, 2023
8 checks passed
@spetrovic77 spetrovic77 deleted the deploy_custom_namespace branch September 18, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants