Replaced internal services with pod watching. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, weavelets communicated with one another via a Kubernetes service. This had two problems. First, a weavelet would try to contact the service before any backing pods started, which led to crashes. Second, a weavelet would contact the service to get an IP address and then use this IP address for all future calls, effectively bypassing our load balancing entirely. This PR fixes the issues by directly watching pods and getting their IP addresses rather than using a service. I believe the internal services we generate are now not needed, but I need to double check and will delete it in a future PR.
spetrovic77
reviewed
Jul 29, 2023
I also fixed a small bug when detecting if a change happened when a pod is deleted, and I merged two goroutines into one.
rgrandl
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, weavelets communicated with one another via a Kubernetes service. This had two problems. First, a weavelet would try to contact the service before any backing pods started, which led to crashes. Second, a weavelet would contact the service to get an IP address and then use this IP address for all future calls, effectively bypassing our load balancing entirely.
This PR fixes the issues by directly watching pods and getting their IP addresses rather than using a service. I believe the internal services we generate are now not needed, but I need to double check and will delete it in a future PR.