workflow: added Integration Tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
force-pushed
the
integration
branch
3 times, most recently
from
9cebfd0
to
69a0217
Compare
chore: fixed collatz with GLIBC_2.32 chore: increment timeout chore: fixed wait command
|
Please note, the workflow failure due to permission to push docker image. You can check the work version from this PR instead: giautm#3 |
mwhittaker
reviewed
Jul 7, 2023
.github/workflows/integration.yml
Outdated
| # Ensure the binary is executable | ||
| chmod +x ./collatz | ||
| # Build the docker image and push | ||
| weaver-kube deploy weaver.toml |
There was a problem hiding this comment.
You mentioned this step is failing because it is not permitted to upload a container to ghcr.io/ServiceWeaver/weaver-kube/example-collatz. What do we have to do to make that work?
There was a problem hiding this comment.
Hey, It just because I don't have write permission on this repo. So, my PR also don't have permission to create a new package for storing docker image.
There was a problem hiding this comment.
Ah gotcha. Thanks for explaining!
giautm
force-pushed
the
integration
branch
2 times, most recently
from
fd9fbfd
to
9892c49
Compare
mwhittaker
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.