Fix time representation #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There's no need to visit all layers, just the timezone ones. - Timezones are far from rectangular, testing against their bounds gives wrong results in far too many cases. - The value in `time_zone` property is a fixed offset, not taking into account DST changes, so can't be used directly. - You can now add a `timezone` property to users to override detection by coordinates (the timezones plugin has stale data, some timezones have changed). - Changed output format to use client's locale, instead of Swedish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time_zoneproperty is a fixed offset, not taking into account DST changes, so can't be used directly.timezoneproperty to users to override detection by coordinates (the timezones plugin has stale data, some timezones have changed).