Feature - Support PHP 8.4 #39
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump phpstan/phpstan from ^1.12 to ^2.1 - Fix errors found by phpstan
tatu-kulmala
force-pushed
the
feature/php-8.4
branch
from
c8fbbe1 to
fb7a9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains code additions and modifications to support PHP version 8.4.
Key changes include:
jumbojett/openid-connect-phpfrom^1.0todev:masterphpstan/phpstanfrom^1.12to^2.1.rector/rectorto help with refactoring processCloses: #9
Impact assessment
Conflict between these details and the actual implementation is considered as
critical bug, preventing the merge. Ie. reviewer must reject PR if such
conflicts exist.
Justify your decision.
Users
What user groups are affected by this change? Ie.
Remember to describe how, ie. if some feature changes/is added/access is
limited etc.
Services
Does this feature interact with other services: either internal or third-party?
Security and privacy
Does this feature impact security or data privacy and if yes, how?
Eg. does this change affect the visibility of services (eg. expose new
endpoints), security configuration, or eg. how we handle Personally
Identifiable Information (PII)? Or eg. does this begin creating new PII?
Confidentiality
Does this feature affect the Confidentiality?
Integrity
Does this feature affect the Integrity?
Availability
Does this feature affect the Availability?
Privacy
What classes of personally identifiable information (PII) is being created
after this feature is implemented? What PII this feature handles?
Processes and workflows
Does this change impact companys internal processes or workflows, ie. how we do
certain tasks - whether tasks is done by automation or by human?
Alternatives
Describe alternatives you've considered. A clear and concise description of any
alternative solutions or features you've considered.
Definition of Done
The Definition of Done should encapsulate all of the items that must be checked
off in order to consider the product shippable.
When fixing bugs, your tests should always test that bug can't resurface later.
Notes for reviewer
Where should a reviewer start?
Manual testing steps?
Screenshots
Related
Any related material, upstream documentation, or other material that makes it
easier to assess the impact and quality of the change.