Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove telescope mobile app #3805

Merged
merged 1 commit into from
Apr 6, 2023
Merged

remove telescope mobile app #3805

merged 1 commit into from
Apr 6, 2023

Conversation

manekenpix
Copy link
Member

@manekenpix manekenpix commented Apr 6, 2023 •
edited
Loading

Issue This PR Addresses

Part of #3800

Description

This PR removes Telescope's mobile app.

Steps to test the PR

N/A

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix self-assigned this Apr 6, 2023
@manekenpix manekenpix added type: documentation (docs) Improvements or additions to documentation area: React Native labels Apr 6, 2023
@manekenpix manekenpix requested review from humphd and Kevan-Y April 6, 2023 22:50
@manekenpix manekenpix marked this pull request as ready for review April 6, 2023 22:53
cindyorangis
cindyorangis previously approved these changes Apr 6, 2023
View reviewed changes
humphd
humphd previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting slimmer every day, love it!

@humphd
Copy link
Contributor

humphd commented Apr 6, 2023

There is probably some mobile app setup/build/project I can delete now, right? I don't remember the details. Anyone remember what I setup?

@manekenpix manekenpix dismissed stale reviews from humphd and cindyorangis via 640f9b0 April 6, 2023 23:25
Kevan-Y
Kevan-Y approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@Kevan-Y Kevan-Y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Some deployments secretly token with EXPO in GitHub action (I think) can be deleted.
The Expo project that was hosting the app.

@manekenpix manekenpix merged commit 9b66ce3 into Seneca-CDOT:master Apr 6, 2023
@manekenpix manekenpix deleted the remove-mobile branch April 6, 2023 23:52
@humphd
Copy link
Contributor

humphd commented Apr 7, 2023

I've deleted the Expo project and secret, thanks @Kevan-Y!

This was referenced Sep 30, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevan-Y Kevan-Y Kevan-Y approved these changes

@humphd humphd humphd left review comments

@cindyorangis cindyorangis cindyorangis left review comments

Assignees

@manekenpix manekenpix

Labels
area: React Native type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manekenpix @humphd @cindyorangis @Kevan-Y