Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup): fix ability to not hide popup on scroll #4490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

konradkierus
Copy link

Fixes #4483 and #4476

In some implementations hideOnScroll being always truthy could cause popups to close and open all the time, for example if body height gets changed which could trigger scroll event and automatically close just opened popup.

As a result the issue could be a bit showstopper to migrate to v3 as there doesn't seem to be a way to workaround the issue without merging this PR and deploying next beta version (CC @layershifter)

Copy link

welcome bot commented Aug 22, 2024

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:48am

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (1623c8d) to head (cf46d45).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4490   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files         186      186           
  Lines        3465     3465           
=======================================
  Hits         3448     3448           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup does not stay open on scroll
1 participant