fix(Popup): fix ability to not hide popup on scroll #4490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4483 and #4476
In some implementations
hideOnScroll
being always truthy could cause popups to close and open all the time, for example if body height gets changed which could trigger scroll event and automatically close just opened popup.As a result the issue could be a bit showstopper to migrate to v3 as there doesn't seem to be a way to workaround the issue without merging this PR and deploying next beta version (CC @layershifter)