Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace lodash invoke with optional chaining #4482

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CrazyStevenz
Copy link

@CrazyStevenz CrazyStevenz commented May 21, 2024

This PR takes the original work of #4428 and addresses the import comments, as well as some other linting errors. I used their commit directly, so they appear as the author, thus properly crediting them in my opinion.

Semantic UI React is the only package we're using that requires lodash, so I'd like to help get closer to the point where you can stop depending on it.

Copy link

welcome bot commented May 21, 2024

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:39pm

@CrazyStevenz
Copy link
Author

I'm not sure what the type of onMouseLeave in the Rating.js component should be to satisfy the failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants