-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass props and other data separately into all component callbacks #4465
base: master
Are you sure you want to change the base?
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4465 +/- ##
==========================================
- Coverage 99.50% 99.50% -0.01%
==========================================
Files 186 186
Lines 3465 3464 -1
==========================================
- Hits 3448 3447 -1
Misses 17 17 ☔ View full report in Codecov by Sentry. |
ACK on this, I won't be able to check this in upcoming two weeks, but I will follow up later. Thx |
Resolves #4464
All callbacks to components which need to process some internal value of the component have had to pull the data out of the object intended to mirrors the props that were passed into the component back to the parent. This PR separates those concepts, so that the callbacks receive internal values of components as separate parameters from the props object.
These are clearly breaking changes but they make the API cleaner and make it possible to see what values (including their types) the callbacks.
To make them easier to review, the changes are broken up into commits by each component which needed to be updated. All tests pass locally after every commit.