Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): Fix missing rendering of icons in selection mode #4347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Dropdown): Fix missing rendering of icons in selection mode #4347

wants to merge 1 commit into from

Conversation

Fox32
Copy link

@Fox32 Fox32 commented Mar 24, 2022

Closes #4346

@welcome
Copy link

welcome bot commented Mar 24, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@Fox32 Fox32 mentioned this pull request Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon for the selected option is not shown in selection Dropdowns
1 participant
@Fox32