Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dropdwon inline ,search with no results found and documentation #4203

Closed
wants to merge 2 commits into from
Closed

fix dropdwon inline ,search with no results found and documentation #4203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1482f29
fix dropdwon inline ,search with no results found and documentation
ivankenou May 8, 2021
dce104d
fix dropdwon inline ,search with no results found and documentation
ivankenou May 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/src/examples/modules/Dropdown/Types/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ const DropdownTypesExamples = () => (
description='A dropdown can be formatted so that its menu is pointing.'
examplePath='modules/Dropdown/Types/DropdownExamplePointing'
>
<ComponentExample
title='inline Search Selection'
description='Type something that results in no results found in the dropdown search.
The dropdown arrow not being on top of the text.'
examplePath='modules/Dropdown/Types/DropdownExampleInline'
/>
<ContributionPrompt>
The example below shows (roughly) the desired markup but is not
functional since we don't currently support nested dropdowns.
Expand Down
2 changes: 2 additions & 0 deletions src/modules/Dropdown/Dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,6 +1424,8 @@ Dropdown.propTypes = {
}

Dropdown.defaultProps = {
selection: true,
search: true,
additionLabel: 'Add ',
additionPosition: 'top',
closeOnBlur: true,
Expand Down