Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): stop onBlur from being called on dropdown close #2776

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

willb335
Copy link
Contributor

@willb335 willb335 commented May 9, 2018

connects #2641

Change is at line 1120

  • onBlur is no longer called when clicking the dropdown button

@codecov-io
Copy link

codecov-io commented May 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1d795bc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2776   +/-   ##
=========================================
  Coverage          ?   99.74%           
=========================================
  Files             ?      160           
  Lines             ?     2765           
  Branches          ?        0           
=========================================
  Hits              ?     2758           
  Misses            ?        7           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d795bc...faac4c5. Read the comment docs.

@SatishSharma1
Copy link

i am facing the same issue. please help

@stale
Copy link

stale bot commented Jun 21, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 21, 2019
@yniknafs
Copy link

Vote to bring this back - causing issues for me right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants