fix: add max length validation for description field with user feedback in NewLesson form #427
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeWolffo
requested review from
piotr-pajak,
wielopolski,
mateuszszczecina and
MarcinMaciejewski337
…ck in NewLesson form
typeWolffo
force-pushed
the
jw_fix_text_lesson_validation
branch
from
d342370 to
cb170a3
Compare
|
I think we should also implement validation on backend side |
|
@mateuszszczecina there was only BE validation so thats why the error occurs |
|
@typeWolffo I mean we should return a more descriptive error from the backend and a different error code than 500 |
mateuszszczecina
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sentry
Screenshots
Before
After