[rb] Deprecate CDP methods on Firefox

[aguspe]

Description

This PR adds deprecation warnings for all the CDP methods for Firefox

Example of deprecation warnings:

Motivation and Context

Based on https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/

We want to deprecate CDP methods on firefox and encourage Selenium users to use the new BiDi implementation

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Code Consistency Verify that the deprecation warning is shown only when Firefox is actually being used, and that the browser variable is properly set and accessible Error Handling Consider adding error handling for cases where BiDi implementation is not available as an alternative

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Performance	Cache deprecation warning status to improve performance on repeated method calls Consider memoizing the deprecation warning check to avoid repeated evaluations when the intercept method is called multiple times. rb/lib/selenium/webdriver/common/driver_extensions/has_network_interception.rb [63-69] -if browser == :firefox - WebDriver.logger.deprecate( - 'Driver#intercept on Firefox', - 'the new BiDi implementation', - id: :intercept - ) +@firefox_deprecation_shown ||= begin + if browser == :firefox + WebDriver.logger.deprecate( + 'Driver#intercept on Firefox', + 'the new BiDi implementation', + id: :intercept + ) + end end Apply this suggestion Suggestion importance[1-10]: 7 Why: Memoizing the deprecation warning is a good optimization that prevents showing the same warning multiple times, improving both user experience and performance when the intercept method is called repeatedly.	7
Possible bug	Add a safety check for undefined variables to prevent potential runtime errors Consider checking if browser is defined before using it. Add a guard clause to handle cases where the browser type might be undefined. rb/lib/selenium/webdriver/common/driver_extensions/has_devtools.rb [31-37] -if browser == :firefox +if defined?(browser) && browser == :firefox WebDriver.logger.deprecate( 'Driver#devtools on Firefox', 'the new BiDi implementation', id: :devtools ) end Apply this suggestion Suggestion importance[1-10]: 3 Why: While adding a check for defined?(browser) could prevent potential errors, it's likely unnecessary as 'browser' is probably an instance method defined in a parent class. The suggestion is overly cautious.	3

💡 Need additional feedback ? start a PR chat

[p0deje]

We should provide a replacement implementation and mention it in deprecation.

For example,on_log_event should be deprecated in favor of script.add_console_message_handler / script.add_javascript_error_handler.

If we don't have exact replacements yet, I suggest we hold off deprecating the methods (suggestion per https://seleniumhq.slack.com/archives/CBH302726/p1731796745420569?thread_ts=1731576590.042029&cid=CBH302726).