-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi select #644
base: v3
Are you sure you want to change the base?
Multi select #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using yarn
how is it that a package-lock.json
was generated, please remove it and make sure to squash so it won't be in the history.
@corevo oh, weird. Squashed it down to one commit for easier viewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, great work but there are a few experience improvements that are needed
- drag n drop for the entire selection
- holding down the primary modifier (ctrl for windows command for mac) should be additive to the selected commands, currently it has no effect (look at modifier keys to see how we handle it cross os)
- only the last selected command should have the top border (it is used to denote where commands will be inserted when recording)
Thanks a lot for the work put into this, this looks great so far!
david califf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Would be happy to port this to the electron app as well.
Credit to @Jongkeun for initial legwork.
X
in the preceding checkbox, I verify that I have signed the Contributor License Agreement