Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k6): use seldon-mesh svc for envoy k6 tests #6070

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Nov 18, 2024

This PR changes the behaviour of our k6 envoy tests to use the seldon-mesh svc instead of envoy pod ip. This is important to make sure that we can run these tests with multi replicas envoy deployments.

@sakoush sakoush requested a review from lc525 as a code owner November 18, 2024 17:11
@sakoush sakoush added the v2 label Nov 18, 2024
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakoush sakoush merged commit b27e287 into SeldonIO:v2 Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants