Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): adding labels and annotations to a seldonconfig component #5918

Merged
merged 14 commits into from
Sep 25, 2024

Conversation

driev
Copy link

@driev driev commented Sep 18, 2024

What this PR does / why we need it:

This allows for granular customisations, which are described in #5185

Which issue(s) this PR fixes:

Fixes #5185

INFRA-642

Special notes for your reviewer:

@driev driev added the v2 label Sep 18, 2024
@driev driev requested a review from lc525 September 23, 2024 12:27
k8s/Makefile Show resolved Hide resolved
k8s/Makefile Show resolved Hide resolved
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with some minor comments

@driev driev merged commit 41ae0e3 into SeldonIO:v2 Sep 25, 2024
3 checks passed
@driev driev changed the title feat(charts): adding metadata object to a seldonconfig component feat(charts): adding labels and annotations to a seldonconfig component Sep 25, 2024
@driev driev deleted the INFRA-642/per-seldonconfig-component-metadata branch September 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants