Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(o11y): Envoy Grafana Dashbaord #5894

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat(o11y): Envoy Grafana Dashbaord #5894

merged 3 commits into from
Sep 18, 2024

Conversation

driev
Copy link

@driev driev commented Sep 13, 2024 •
edited
Loading

What this PR does / why we need it:

This adds an envoy grafana dashboard, which is useful to have better o11y of envoy.

Fixes #

It is related to INFRA-1150

TODOs:

  • Add some more visualisations, perhaps.

@driev driev marked this pull request as draft September 13, 2024 10:26
@driev driev changed the title Envoy Grafana Dashbaord feat(o11y): Envoy Grafana Dashbaord Sep 13, 2024
lc525
lc525 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakoush sakoush added the v2 label Sep 17, 2024
@driev driev marked this pull request as ready for review September 18, 2024 09:40
@driev driev merged commit d28c58c into SeldonIO:v2 Sep 18, 2024
4 checks passed
@driev driev deleted the INFRA-1150/envoy-dashboard branch September 18, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc525 lc525 lc525 approved these changes

@sakoush sakoush Awaiting requested review from sakoush sakoush is a code owner

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driev @lc525 @sakoush