Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New documentation site for Seldon Core v2 #5760

Merged
merged 33 commits into from
Sep 9, 2024

Conversation

ramonpzg
Copy link
Contributor

@ramonpzg ramonpzg commented Jul 16, 2024

The main purpose of this PR is to migrate our docs from readthedocs to GitBook.

Here are the changes I have made to transition the docs from one place to another.

Edits ✍️

  • Moved all documents out of source
  • Captions inside of mermaid diagrams have been moved to underneath the diagram as markdown.

Add Ons 🚀

  • SUMMARY.md file at the root of the docs directory to organize the docs.
  • I added a new directory called images to the docs directory and most images reside there now. I have added the correct path where necessary.
  • Referenced code via tags such as {literalinclude} have been replaced by the actual code these were referencing.
  • Mermaid diagram sections now start with mermaid as opposed to {mermaid}.
  • Block quotes such as {note} or {warning} you now need to surround block quotes with {% hint style="warning" %} and {% endhint %} (for more information see here).
  • Examples inside the docs directory now contain full documents rather than a reference. This includes:
    • Huggingface speech to sentiment pipeline

Removed 🧹

Removed all files related to Sphinx and readthedocs.

  • Makefile
  • make.bat
  • requirements-docs.txt
  • index.md
  • conf.py
  • .gitignore - the files in it are now in the main .gitignore in the root directory of the repo
  • {toctree} at the end of most markdown files as gitbook provides this functionality
  • {literalinclude} and other references to different code files.
  • Full tutorials available in different directories should be edited from the docs as opposed to being references from the samples directory. This will help create a single place for tutorials and examples and minimize references to different files.

Admin 💼

  • All code references to full files now use GitHub Gist to stay up to date with master. Any suggestions on how to keep this in sync with branches for different versions of the docs, would be much appreciated.

Follow-Up Work (Different PR) 🤝

  • references to source of truth files

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@lc525 lc525 added the v2 label Jul 16, 2024
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ramonpzg
❌ gitbook-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@lc525
Copy link
Member

lc525 commented Jul 22, 2024

@ramonpzg I would like to form a view on the upgrade path to GitBook & timelines. At the moment, if I want to write some more Core 2 docs, would you recommend waiting for this PR to be merged first?

@ramonpzg
Copy link
Contributor Author

@ramonpzg I would like to form a view on the upgrade path to GitBook & timelines. At the moment, if I want to write some more Core 2 docs, would you recommend waiting for this PR to be merged first?

@lc525 -- I will have the PR ready for review by sometime this week and would recommend waiting until the new docs have been merged. The reason is that since the docs directory structure has changed completely, rebasing with v2 to get the new changes might complicate things a bit. If these need to go out asap then no worries and move ahead with the changes. I can always look up the files that changed and update them manually on my branch.

@lc525
Copy link
Member

lc525 commented Jul 23, 2024

I will have the PR ready for review by sometime this week and would recommend waiting

@ramonpzg It's not that urgent, I can wait for this to be merged. Thank you for your work on this!

docs/README.md Outdated Show resolved Hide resolved
docs/pipelines/index.md Outdated Show resolved Hide resolved
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with requested changes. Most I believe are minor, but I see the ability to include file contents (that was previously discussed) as very important.

@ramonpzg ramonpzg changed the base branch from v2 to v2-docs-master August 27, 2024 05:07
@ramonpzg
Copy link
Contributor Author

I have created a new branch called v2-docs-master and pointed this PR towards it. Because this new branch was made with the V2 branch as a base, it is possible that there might be a few inconsistencies if the docs have changed in the last 2 weeks.

@lc525 lc525 self-requested a review September 5, 2024 12:35
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as a base, further changes to be built on top of this PR

To summarise our discussion, as next tasks:

  • @ramonpzg to investigate ways in which file references can point to the file corresponding to the exact release branch/tag rather than to v2
  • core 2 team to define changes required to the release process and test those

@ramonpzg ramonpzg merged commit 0d406c7 into SeldonIO:v2-docs-master Sep 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants