-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New documentation site for Seldon Core v2 #5760
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@ramonpzg I would like to form a view on the upgrade path to GitBook & timelines. At the moment, if I want to write some more Core 2 docs, would you recommend waiting for this PR to be merged first? |
@lc525 -- I will have the PR ready for review by sometime this week and would recommend waiting until the new docs have been merged. The reason is that since the docs directory structure has changed completely, rebasing with v2 to get the new changes might complicate things a bit. If these need to go out asap then no worries and move ahead with the changes. I can always look up the files that changed and update them manually on my branch. |
@ramonpzg It's not that urgent, I can wait for this to be merged. Thank you for your work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with requested changes. Most I believe are minor, but I see the ability to include file contents (that was previously discussed) as very important.
…with enhancements
4c7adc1
to
5e3cbbf
Compare
19b7bfa
to
05bb232
Compare
I have created a new branch called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as a base, further changes to be built on top of this PR
To summarise our discussion, as next tasks:
- @ramonpzg to investigate ways in which file references can point to the file corresponding to the exact release branch/tag rather than to
v2
- core 2 team to define changes required to the release process and test those
The main purpose of this PR is to migrate our docs from readthedocs to GitBook.
Here are the changes I have made to transition the docs from one place to another.
Edits ✍️
source
mermaid
diagrams have been moved to underneath the diagram as markdown.Add Ons 🚀
SUMMARY.md
file at the root of the docs directory to organize the docs.images
to thedocs
directory and most images reside there now. I have added the correct path where necessary.{literalinclude}
have been replaced by the actual code these were referencing.mermaid
as opposed to{mermaid}
.{note}
or{warning}
you now need to surround block quotes with{% hint style="warning" %}
and{% endhint %}
(for more information see here).Removed 🧹
Removed all files related to Sphinx and
readthedocs
.Makefile
make.bat
requirements-docs.txt
index.md
conf.py
.gitignore
- the files in it are now in the main.gitignore
in the root directory of the repo{toctree}
at the end of most markdown files as gitbook provides this functionality{literalinclude}
and other references to different code files.docs
as opposed to being references from thesamples
directory. This will help create a single place for tutorials and examples and minimize references to different files.Admin 💼
master
. Any suggestions on how to keep this in sync with branches for different versions of the docs, would be much appreciated.Follow-Up Work (Different PR) 🤝