fix(scheduler): Deal with deleted experiments when restoring from cache #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
reviewed
Jun 27, 2024
scheduler/pkg/store/experiment/db.go
Outdated
| err = startExperimentCb(experiment) | ||
| if err != nil { | ||
| return err | ||
| // skip restoring the experiment if the callback returns an error |
There was a problem hiding this comment.
May I suggest we slightly alter the comment to avoid confusion: the code doesn't skip anything, it simply swallows the error and logs a warning. If we would have bubbled the error up, that would end up stopping the scheduler with a Fatal error in main().
I was thinking of something like: "If the callback fails, do not bubble the error up but simply log it as a warning. The experiment restore is skipped instead of the scheduler failing due to the returned error."
lc525
approved these changes
Jun 27, 2024
sakoush
commented
Jul 1, 2024
| @@ -73,13 +76,46 @@ func (edb *ExperimentDBManager) restore(startExperimentCb func(*Experiment) erro | |||
| return err | |||
| } | |||
| experiment := CreateExperimentFromRequest(&snapshot) | |||
| if experiment.Deleted { | |||
There was a problem hiding this comment.
this is the crux of the change. we store now deleted and on restoring we just add the experiment to the in-memory store without (re)starting it.
sakoush
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that re-loads deleted experiments after scheduler restarts. This is further complicated by the fact that these reloaded experiments are only visible from the scheduler state and not from kubernetes state.
The underlying cause was that we didn't check experiments state (whether they are deleted) when restoring from disk on scheduler restarts.
This PR adds this check and the necessary changes.
This PR also skips loading experiments if they fail validation. Importantly it will not fail the scheduler from starting is this happens a validation for a particular experiment fail. This is something that got exposed by this bug.
Note that for pipelines we do not have a validation step when restoring from disk.
Implementation
Adding
ExperimentSnapshotproto inmlops/scheduler/storage.proto, that has an extra fieldDeletedto the experiment protos that we persist on disk so that on restore we can check whether the experiment is deleted.Added also
gethelper from DB (badgerdb) so that we can tests whats stored on disk. I also increased tests coverage while working on this area of the codebase.fixes: INFRA-1055 (internal)
TODO: