Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fail_ci_if_error to false on codecov github acton #776

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

mauicv
Copy link
Collaborator

@mauicv mauicv commented Apr 24, 2023

What is this

Sets fail_ci_if_error=false in the codecov github ci. Quick fix that prevents the ci from falling due to this issue. See also #768

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #776 (a888212) into master (98a2802) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   81.02%   80.96%   -0.06%     
==========================================
  Files         146      146              
  Lines        9716     9716              
==========================================
- Hits         7872     7867       -5     
- Misses       1844     1849       +5     

see 2 files with indirect coverage changes

@ascillitoe
Copy link
Contributor

The ubuntu-latest, 3.9 build gives us an example of the codecov upload failing and CI still passing (which is what we want) 👍🏻

@mauicv mauicv merged commit 8a945ce into SeldonIO:master Apr 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants