-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat import export binary and decimal seed #608
base: dev
Are you sure you want to change the base?
Feat import export binary and decimal seed #608
Conversation
Hi @nosedam . Great job! I just tested your commit and it does what PR states and issue asks. Further, I tested on 3.10 and 3.12 pytest, and both passed. |
Thanks for trying it @fedebuyito! I will try to improve the binary numbers export and validation by introducing space separation or different colors, so Its easier to identify which digit you are reading. |
Hi @nosedam . That seems to be fine! Pytested, too. All passed. |
Description
This change allows to export and import the seed phrase in binary and decimal format.
Mentioned here: #68
export_binary.mp4
export_decimal.mp4
import_binary.mp4
import_decimal.mp4
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Thanks everyone for checking the PR. All feedback is appreciated!
Any changes that I need to do just tell me!