Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat import export binary and decimal seed #608

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

nosedam
Copy link

@nosedam nosedam commented Sep 14, 2024

Description

This change allows to export and import the seed phrase in binary and decimal format.
Mentioned here: #68

export_binary.mp4
export_decimal.mp4
import_binary.mp4
import_decimal.mp4

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A (it uses the same original flows, it just uses new keyboards to translate their values to a mnemonic word and continue with original flow)

I have tested this PR on the following platforms/os:

Thanks everyone for checking the PR. All feedback is appreciated!
Any changes that I need to do just tell me!

@fedebuyito
Copy link
Contributor

Hi @nosedam . Great job! I just tested your commit and it does what PR states and issue asks. Further, I tested on 3.10 and 3.12 pytest, and both passed.

@nosedam
Copy link
Author

nosedam commented Oct 14, 2024

Thanks for trying it @fedebuyito! I will try to improve the binary numbers export and validation by introducing space separation or different colors, so Its easier to identify which digit you are reading.

@nosedam
Copy link
Author

nosedam commented Oct 30, 2024

Hi guys, I added a color feature to prevent confusions in seed binary export
image

@fedebuyito
Copy link
Contributor

Hi @nosedam . That seems to be fine!

image

image

Pytested, too. All passed.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants