Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] MicroSD toast timer settings #600

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

alvroble
Copy link
Contributor

@alvroble alvroble commented Sep 3, 2024

STILL IN PROGRESS

Description

Proposed solution for issue #546

Provides 3 microSD options:

  • Toast disabled
  • 5-sec toast (default)
  • SD card removal required* (fullscreen dialog, cannot proceed unless microSD is removed)

SettingsEntryUpdateSelectionView_microsd_toast_timer

For the third option, the new warning dialog UI (re-used and old View class that was unused) looks as follows:

RemoveMicroSDWarningView

So the user can choose between:

  • Remove MicroSD and then press "Continue"
  • Press "Dismiss" to modify persistent settings before removing the MicroSD

This behaviour has the possibility to be different. In previous commit 2554647, a fullscreen toast with no dialog options is shown instead of the warning dialog. Here, user must remove MicroSD to continue. However, as persistent settings must be written to the MicroSD to continue, user should have to insert it again if they wanted to hange the settings.

That behaviour was a bit more confusing for the user but is still an option if most devs agree on it.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

Provides 3 microSD options:
- Toast disabled
- 5-sec toast (default)
- SD card removal required* (fullscreen dialog,
cannot proceed unless microSD is removed)
"SD card removal required" option: warning view
shown instead of fullscreen toast so user can
disable this setting without removing SD card.
@newtonick
Copy link
Collaborator

newtonick commented Sep 5, 2024

Comment related to this PR left here: #546 (comment)

I live the setting options, but option 3 still needs work.

@alvroble
Copy link
Contributor Author

alvroble commented Sep 6, 2024

Thanks @newtonick for your comments. Just to continue here the discussion. I'll mark this PR as draft until we clarify the third option UX and flow.

I will test how can we manage to have this warning screen:

363503351-a21c6291-6de3-4137-9843-0636a42ddea0

With this behavior:

  • If user removes SD card, show main menu view.
  • If they push the settings button, bring them directly to this setting

In the settings, as @newtonick proposed, we could make it work as if

when the user selects the back "<" arrow, the "Remove Memory Card" would re-evaluate the state of things and proceed accordingly.

I think this may be too complex of a refactor but a nice feature to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants