[Enhancement] MicroSD toast timer settings #600
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STILL IN PROGRESS
Description
Proposed solution for issue #546
Provides 3 microSD options:
For the third option, the new warning dialog UI (re-used and old View class that was unused) looks as follows:
So the user can choose between:
This behaviour has the possibility to be different. In previous commit 2554647, a fullscreen toast with no dialog options is shown instead of the warning dialog. Here, user must remove MicroSD to continue. However, as persistent settings must be written to the MicroSD to continue, user should have to insert it again if they wanted to hange the settings.
That behaviour was a bit more confusing for the user but is still an option if most devs agree on it.
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: