fixed httpserver.r2py to work properly for Repy v2 and new unit test for it #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test file for httpserver.r2py
unit test for httpserver.r2py
Updated doc string to have some more info
us341
changed the title
|
| # raises. However, it just raises plain exceptions. | ||
| # Read chunks from the callback and efficiently send them to | ||
| # the client using HTTP/1.1 chunked encoding. | ||
| _httpserver_sendfile_chunked(sock, messagestream) |
There was a problem hiding this comment.
May be try-catch block is required here or in httpserver_sendfile_chunked to handle the "filelikeobj.read" exceptions?
There was a problem hiding this comment.
filelikeobj is object of _httpserver_StringIO class and read() is calling this class's read method. It is handling the ValueError if the class object is closed.
httpretrieve.r2py is left intentionaly as dylink.r2py needs some ammendment
restrictions.threeports is added in place of restrictions.default as two different ports were needed for callback method hosted on server and client
Also mentioned the reason in comments to leave httpretrieve.r2py module with dy_import_module_symbols
Changed waitforconn docstring for callback function to take five arguments instead of one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.