Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to rebuild_base_installers_for_seattlegeni.sh. #136

Closed
wants to merge 3 commits into from

Conversation

aot221
Copy link
Contributor

@aot221 aot221 commented Jun 12, 2014

  • The SOFTWARE_UPDATE_URL was updated.
  • The user was made configurable.

* The SOFTWARE_UPDATE_URL was updated.
* The user was made configurable.
@aaaaalbert
Copy link
Contributor

A minor note, variable names in bash sripts are usually ALL_CAPS.

Following the discussion during the team meeting, please also create a ticket describing the reason and objective for your fix.

@aot221
Copy link
Contributor Author

aot221 commented Jun 16, 2014

This fix was made in response to ticket #124.

The ticket said that the custom installer builder was expecting:

seattle_android.zip
seattle_linux.tar.gz
seattle_mac.tar.gz
seattle_windows.zip

The ticket recommends to omit the version part of the names to reduce headache. However, this is unnecessary because of the symlinks that are created on lines 101-103 of the old code which are already doing that.

sudo -u geni ln -s -f seattle_${VERSION}_linux.tgz seattle_linux.tgz
sudo -u geni ln -s -f seattle_${VERSION}_mac.tgz seattle_mac.tgz
sudo -u geni ln -s -f seattle_${VERSION}_win.zip seattle_win.zip

The creator of ticket #124 did not have the symlinks being created on the machine he was working on becayse he didn't have the geni user. Symlinks were not mentioned in the ticket because they were not part of the documentation and it was not known that they existed.

I learned that the user "geni" is specific to the Seattle production machine. I replaced it with a variable so that it could be configured to work on machines without the geni user.

There was also an issue with the SOFTWARE_UPDATE_URL not working(it does not redirect) so that was updated.

Before I uploaded a fix onto github I wanted to test it on the custom installer builder so I followed these steps(https://seattle.poly.edu/wiki/CustomInstallerBuilderTesting). It should also be noted that the CustomInstallerBuilderTesting webpage needs to be updated to mention that the username can be configured and that the /path/to part of

PUBLIC_KEY_FILE=/path/to/softwareupdater.publickey
PRIVATE_KEY_FILE=/path/to/softwareupdater.privatekey
needs to be changed to where the user left his public and private key.

@aaaaalbert
Copy link
Contributor

This pull request is merged in branch git-aware-buildscripts.

@aaaaalbert aaaaalbert closed this Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants