Update build_component.py #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added proper error message with link to build instructions.
| script is not meant to be called individually, but through \ | ||
| a wrapper script, build.py. See the Seattle build instructions \ | ||
| wiki for details: https://seattle.poly.edu/wiki/BuildInstructions" | ||
| return 0 |
There was a problem hiding this comment.
You might want to raise an exception here, or call sys.exit(1) (similar to help_exit()'s approach.
There was a problem hiding this comment.
The official Python tutorial has a section on exceptions. One approach you may follow here is to log/print information about the requiredscripts/config_build.txt file, and then re-raise the exception with a bare raise (to avoid masking the original exception).
The following article explains why exceptions can lead to cleaner code:
Write Cleaner Python: Use Exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proper error message with link to build instructions.