Added Support for Fetch Modes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
769344359
reviewed
Dec 17, 2019
| @@ -167,9 +157,9 @@ zend_module_entry SeasClick_module_entry = | |||
| SEASCLICK_RES_NAME, | |||
| SeasClick_functions, | |||
| PHP_MINIT(SeasClick), | |||
| PHP_MSHUTDOWN(SeasClick), | |||
There was a problem hiding this comment.
why remove shutdown callback?
There was a problem hiding this comment.
It doesn't do anything, so recommended approach is to not invlude PHP_MSHUT / PHP_MINIT unless they do something
aiwhj
reviewed
Dec 18, 2019
| @@ -98,6 +99,9 @@ const zend_function_entry SeasClick_methods[] = | |||
| PHP_FE_END | |||
| }; | |||
|
|
|||
| #define REGISTER_SC_CLASS_CONST_LONG(const_name, value) \ | |||
| zend_declare_class_constant_long(SeasClick_ce, const_name, sizeof(const_name)-1, (zend_long)value); | |||
There was a problem hiding this comment.
Please do some compatibility tests, such as zend_long type does not support PHP 5 version
SeasClick.cpp
Outdated
| convertToZval(col2, block[1], row, "", 0, fetch_mode|SC_FETCH_ONE); | ||
|
|
||
| if (Z_TYPE_P(col1) == IS_LONG) { | ||
| zend_hash_index_update(Z_ARRVAL_P(return_value), Z_LVAL_P(col1), col2); |
There was a problem hiding this comment.
Compatibility
#define zend_hash_index_update(ht, h, pData, nDataSize, pDest) _zend_hash_index_update_or_next_insert(ht, h, pData, nDataSize, pDest, HASH_UPDATE ZEND_FILE_LINE_CC)
This is the definition of PHP 5 version
Upgraded clickhouse lib to v1.1.0 Added ability control connection, recv, timeouts & retry settings
|
@769344359 @Neeke Any chance to get it merged? |
it will have been merged when i finsh unit tests! |
|
@guba-odudkin could you please help me to fix the conflicts ? it change a lot of file, i can not merge it . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of feature enhancements to simplify data retrieval
Also added SeasClickException class so that exceptions thrown are specific to extension as opposed to using generic Exception class.