Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbolic icon #24

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Add symbolic icon #24

merged 2 commits into from
Feb 4, 2024

Conversation

yavko
Copy link
Contributor

@yavko yavko commented Mar 21, 2022

Adds a symbolic icon
semi fixes #23

@yavko
Copy link
Contributor Author

yavko commented Mar 21, 2022

I came up with the idea of a ribbon because its note "worthy", so I thought a ribbon could signify worthiness I guess. This is one of my first icons, I'm not great with graphic design.

@yavko yavko mentioned this pull request Mar 21, 2022
2 tasks
@SeaDve
Copy link
Owner

SeaDve commented Mar 23, 2022

Thanks! It kinda looks stretched on the preview. Other than that, looking good

@yavko
Copy link
Contributor Author

yavko commented Mar 23, 2022

Thanks! It kinda looks stretched on the preview. Other than that, looking good

Weird, maybe its because its not 1:1, but most symbolic icons aren't anyways?

@SeaDve
Copy link
Owner

SeaDve commented Mar 23, 2022

I think it should have 1:1 ratio. App Icon Preview from flathub may be helpful as a guide for size. It has a template that can be opened with SVG editor like inkscape, plus a preview

@yavko
Copy link
Contributor Author

yavko commented Mar 23, 2022

I think it should have 1:1 ratio. App Icon Preview from flathub may be helpful as a guide for size. It has a template that can be opened with SVG editor like inkscape, plus a preview

I looked at the symbolic icons in adwaita and they seem to be scaled to the icons borders, but idk.

@yavko
Copy link
Contributor Author

yavko commented Mar 23, 2022

I'll make a commit with the icon as 1:1 anyways though

@yavko
Copy link
Contributor Author

yavko commented Mar 30, 2022

@SeaDve Fixed the icon!

@SeaDve
Copy link
Owner

SeaDve commented Feb 4, 2024

Thanks! sorry for the very late reply. Merged.

@SeaDve SeaDve merged commit 696e600 into SeaDve:main Feb 4, 2024
@yavko
Copy link
Contributor Author

yavko commented Feb 4, 2024

Thanks! sorry for the very late reply. Merged.

Oh, no problem, are you planning on continuing development?

@SeaDve
Copy link
Owner

SeaDve commented Feb 4, 2024

Nope, unfortunately, not any time soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon?
2 participants