Repository navigation
chore(sessions): attribute Codex per-rollout store waits - #4745
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 4, 2026
Integrate PR #4745 at 9f2ae73 into the existing #4742 draft, preserving both branch histories. Both changed files matched the source PR's original blobs in the consolidated tree, so retain the source blobs exactly without conflicts. Only the four trace-level timing boundaries are added; existing storage, LCM, search, SQLite lifetime repairs and release metadata stay unchanged. This is consolidation into the draft branch, not a merge into master. Source-reviewed only; combined-head hosted Bazel validation is still required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated into #4742
Closed as superseded by the existing consolidated draft #4742 at commit
7a9f53506df27f122dbd872180656963cd3fbb4a.The complete source head
9f2ae73dc4a9cdf8a8aa7c07e3bae8b429c65c36is a parent of that integration commit. Both changed files were included byte-for-byte; the existing consolidation and its follow-up repairs were preserved. This source branch is retained. This is not a merge into master or a test-pass claim; combined-head Bazel validation remains required in #4742.Scope
Refs #4374. The remaining project-scope Codex replay slowdown was measured at roughly 28 ms per unchanged rollout, but the existing top-level admission span does not attribute the store read/write and membership components separately. This change adds four trace-level timing boundaries around the existing operations:
The current convergence-check and Codex admission spans remain intact. These nested timings let an operator compare project-scope reoffers using
RUST_LOGandTRACEDECAY_SPAN_TIMINGS=1before deciding whether the root cause is a per-rollout durable write, cursor lookup, blocking-worker scheduling, or something else. The shared JSONL admission spans also cover other providers without changing their contracts.Safety and review
The exact admission operations, return values, cancellation/error handling, cursor state, scope matching, and store writes are unchanged. Source-reviewed as a two-file trace-only diff against
masterf64ec1f3. No new persistence authority, admission shortcuts, limits, or silent fallbacks.Validation and limits
Keep #4374 open; profile-scope fix #4380 is already merged but project-scope latency remains unresolved.