refactor(architecture): name contracts and application layers - #1106
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5866a5492e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "crates/tracedecay-store-runtime", | ||
| "crates/tracedecay-tool-catalog", | ||
| "crates/tracedecay-usecases", | ||
| "crates/tracedecay-application", |
There was a problem hiding this comment.
Retarget the executable boundary baseline to contracts
When benchmark_data/pr11-application-boundary/validate_compile_baseline.py --run is used, the unchanged baseline command cargo check -p tracedecay-application now selects the former use-cases crate introduced at this workspace entry, rather than the dependency-light boundary whose recorded measurement asserts that it has no store or model-runtime edges. This produces a candidate measurement for a materially different package; retarget the executable fixture to tracedecay-contracts so the rename migrates this caller as well.
AGENTS.md reference: AGENTS.md:L130-L132
Useful? React with 👍 / 👎.
Performance Comparison
|
…plan-reopened' into sol/layer-names-1075 # Conflicts: # Cargo.lock # crates/tracedecay-application/src/tracedecay/mod.rs # crates/tracedecay-application/tests/source_edit_candidate_authority.rs # crates/tracedecay-source-edit/Cargo.toml # crates/tracedecay-source-edit/src/digest.rs # crates/tracedecay-source-edit/src/execute.rs # crates/tracedecay-source-edit/src/journal.rs # crates/tracedecay-source-edit/src/lib.rs # crates/tracedecay-source-edit/src/plan.rs # crates/tracedecay-source-edit/src/reconcile.rs # crates/tracedecay-source-edit/src/rollback.rs # crates/tracedecay-source-edit/src/verify.rs # crates/tracedecay-usecases/Cargo.toml # crates/tracedecay-usecases/src/lib.rs # crates/tracedecay/src/tracedecay/edits/primitives.rs # crates/tracedecay/src/tracedecay/edits/rename.rs # crates/tracedecay/src/tracedecay/edits/rename/graph_evidence.rs # crates/tracedecay/src/tracedecay/edits/symbols.rs # crates/tracedecay/src/tracedecay/move_symbol/mod.rs # crates/tracedecay/src/tracedecay/project_runtime_port.rs
1d90a66
into
codex/tracedecay-total-redesign-plan-reopened
Summary
tracedecay-applicationtotracedecay-contractstracedecay-usecasestotracedecay-applicationArchitecture
tracedecay-contractsdepends only on domain/policy/tool-catalog plus ordinary external utilitiestracedecay-applicationdepends on contracts and the runtime/storage owners it orchestratesTests
cargo check --workspace --all-targets(post-base-merge, 0 errors/warnings)cargo clippy --workspace --all-targets -- -D warnings(post-base-merge, 0 errors/warnings)cargo test -p tracedecay-contracts(729 passed)cargo test -p tracedecay-application(681 passed)cargo test -p tracedecay-sdk --tests(44 passed, 3 ignored)Closes #1075.