Skip to content

refactor(architecture): name contracts and application layers - #1106

Merged
ScriptedAlchemy merged 5 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
sol/layer-names-1075
Sep 8, 2026
Merged

refactor(architecture): name contracts and application layers#1106
ScriptedAlchemy merged 5 commits into
codex/tracedecay-total-redesign-plan-reopenedfrom
sol/layer-names-1075

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • rename the bottom ports/contracts crate from tracedecay-application to tracedecay-contracts
  • rename the top orchestration crate from tracedecay-usecases to tracedecay-application
  • update every live Cargo edge, Rust import, feature, script, CI path, SDK surface, benchmark lane, test, and maintained document in one cutover
  • retain no compatibility package, crate alias, or old live path

Architecture

  • tracedecay-contracts depends only on domain/policy/tool-catalog plus ordinary external utilities
  • tracedecay-application depends on contracts and the runtime/storage owners it orchestrates
  • Cargo metadata/tree confirms no reverse dependency cycle

Tests

  • cargo check --workspace --all-targets (post-base-merge, 0 errors/warnings)
  • cargo clippy --workspace --all-targets -- -D warnings (post-base-merge, 0 errors/warnings)
  • cargo test -p tracedecay-contracts (729 passed)
  • cargo test -p tracedecay-application (681 passed)
  • cargo test -p tracedecay-sdk --tests (44 passed, 3 ignored)
  • runtime benchmark Python tests (39 passed)
  • SDK check and 94 additional Python tests
  • formatting, diff checks, commitlint, and live old-alias census

Closes #1075.

@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7d6d87a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T09:40:47.855063Z 5866a54 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5866a5492e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
"crates/tracedecay-store-runtime",
"crates/tracedecay-tool-catalog",
"crates/tracedecay-usecases",
"crates/tracedecay-application",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retarget the executable boundary baseline to contracts

When benchmark_data/pr11-application-boundary/validate_compile_baseline.py --run is used, the unchanged baseline command cargo check -p tracedecay-application now selects the former use-cases crate introduced at this workspace entry, rather than the dependency-light boundary whose recorded measurement asserts that it has no store or model-runtime edges. This produces a candidate measurement for a materially different package; retarget the executable fixture to tracedecay-contracts so the rename migrates this caller as well.

AGENTS.md reference: AGENTS.md:L130-L132

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopenedsol/layer-names-1075

Total Elapsed Time: 4.73s → 5.07s (+7.3%)
CPU Baseline: 90.09µs → 89.75µs (-0.4%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                            | P95                             | Total                            | % Total                      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 4.73s → 5.07s (+7.2%)          | 4.73s → 5.08s (+7.4%)           | 4.73s → 5.07s (+7.2%)            | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.append_pages              | 13 → 13 (+0.0%)            | 170.84ms → 186.51ms (+9.2%)    | 228.46ms → 256.25ms (+12.2%)    | 2.22s → 2.42s (+9.0%)            | 47.00% → 47.81% (+1.7%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 13 → 13 (+0.0%)            | 112.78ms → 116.72ms (+3.5%)    | 151.91ms → 163.45ms (+7.6%)     | 1.47s → 1.52s (+3.4%)            | 31.03% → 29.92% (-3.6%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.workers.install               | 83 → 83 (+0.0%)            | 14.69ms → 17.50ms (+19.1%)     | 48.96ms → 63.64ms (+30.0%) ⚠️   | 1.22s → 1.45s (+18.9%)           | 25.80% → 28.65% (+11.0%)     |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings            | 13 → 13 (+0.0%)            | 102.45ms → 105.74ms (+3.2%)    | 139.59ms → 148.64ms (+6.5%)     | 1.33s → 1.37s (+3.0%)            | 28.18% → 27.11% (-3.8%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| domain.canonical.sha256                  | 110414 → 110414 (+0.0%)    | 9.34µs → 9.55µs (+2.2%)        | 14.58µs → 14.68µs (+0.7%)       | 1.03s → 1.05s (+1.9%)            | 21.82% → 20.80% (-4.7%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 463.08ms → 478.72ms (+3.4%)    | 525.60ms → 544.21ms (+3.5%)     | 926.16ms → 957.44ms (+3.4%)      | 19.60% → 18.88% (-3.7%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 13 → 13 (+0.0%)            | 56.17ms → 57.24ms (+1.9%)      | 76.09ms → 81.40ms (+7.0%)       | 730.20ms → 744.07ms (+1.9%)      | 15.45% → 14.67% (-5.0%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.prepare_pages             | 13 → 13 (+0.0%)            | 46.53ms → 56.35ms (+21.1%) ⚠️  | 63.96ms → 86.77ms (+35.7%) ⚠️   | 604.90ms → 732.61ms (+21.1%) ⚠️  | 12.80% → 14.45% (+12.9%)     |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 14 → 14 (+0.0%)            | 46.90ms → 47.40ms (+1.1%)      | 286.00ms → 291.50ms (+1.9%)     | 656.56ms → 663.66ms (+1.1%)      | 13.89% → 13.09% (-5.8%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 13 → 13 (+0.0%)            | 36.32ms → 45.82ms (+26.2%) ⚠️  | 49.74ms → 69.40ms (+39.5%) ⚠️   | 472.18ms → 595.65ms (+26.1%) ⚠️  | 9.99% → 11.75% (+17.6%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.chunk.index_file              | 276 → 276 (+0.0%)          | 2.01ms → 2.12ms (+5.5%)        | 2.95ms → 3.08ms (+4.4%)         | 556.01ms → 585.64ms (+5.3%)      | 11.77% → 11.55% (-1.9%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 1.87ms → 1.93ms (+3.2%)        | 2.82ms → 2.95ms (+4.6%)         | 516.41ms → 533.64ms (+3.3%)      | 10.93% → 10.52% (-3.8%)      |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings.term_rows  | 13 → 13 (+0.0%)            | 36.38ms → 38.10ms (+4.7%)      | 58.33ms → 59.64ms (+2.2%)       | 472.93ms → 495.34ms (+4.7%)      | 10.01% → 9.77% (-2.4%)       |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.assemble                | 2 → 2 (+0.0%)              | 213.06ms → 219.68ms (+3.1%)    | 223.61ms → 229.24ms (+2.5%)     | 426.13ms → 439.37ms (+3.1%)      | 9.02% → 8.66% (-4.0%)        |
+------------------------------------------+----------------------------+--------------------------------+---------------------------------+----------------------------------+------------------------------+

Generated with hotpath-rs

…plan-reopened' into sol/layer-names-1075

# Conflicts:
#	Cargo.lock
#	crates/tracedecay-application/src/tracedecay/mod.rs
#	crates/tracedecay-application/tests/source_edit_candidate_authority.rs
#	crates/tracedecay-source-edit/Cargo.toml
#	crates/tracedecay-source-edit/src/digest.rs
#	crates/tracedecay-source-edit/src/execute.rs
#	crates/tracedecay-source-edit/src/journal.rs
#	crates/tracedecay-source-edit/src/lib.rs
#	crates/tracedecay-source-edit/src/plan.rs
#	crates/tracedecay-source-edit/src/reconcile.rs
#	crates/tracedecay-source-edit/src/rollback.rs
#	crates/tracedecay-source-edit/src/verify.rs
#	crates/tracedecay-usecases/Cargo.toml
#	crates/tracedecay-usecases/src/lib.rs
#	crates/tracedecay/src/tracedecay/edits/primitives.rs
#	crates/tracedecay/src/tracedecay/edits/rename.rs
#	crates/tracedecay/src/tracedecay/edits/rename/graph_evidence.rs
#	crates/tracedecay/src/tracedecay/edits/symbols.rs
#	crates/tracedecay/src/tracedecay/move_symbol/mod.rs
#	crates/tracedecay/src/tracedecay/project_runtime_port.rs
Regenerate the renamed workspace lockfile from the latest #707 base so the ten Windows-only windows-sys edges retained by cc3042d stay on 0.59 instead of being reverted to 0.52 during conflict resolution.\n\nCargo check --workspace --all-targets --locked now accepts the result.
@ScriptedAlchemy
ScriptedAlchemy merged commit 1d90a66 into codex/tracedecay-total-redesign-plan-reopened Sep 8, 2026
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant