Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .site.IsServer deprecation error #485

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Fix .site.IsServer deprecation error #485

merged 3 commits into from
Aug 23, 2024

Conversation

Samq64
Copy link
Member

@Samq64 Samq64 commented Aug 21, 2024

I thought this was already fixed?

@Samq64 Samq64 added the dependencies Pull requests that update a dependency file label Aug 21, 2024
@Samq64
Copy link
Member Author

Samq64 commented Aug 21, 2024 •
edited
Loading

The Hugo version is too old. Should I update the action or downgrade on my end?

@Hans5958
Copy link
Member

I'd rather have the Hugo version updated. Don't worry if it fails here, just in case. If the deployment works on this PR, it would also work on master.

@Hans5958 Hans5958 added the type: bug Something isn't working (or is wrong in general) label Aug 22, 2024
@Samq64
Copy link
Member Author

Samq64 commented Aug 22, 2024

I'm asking because of

Starting on Hugo 0.120, the minify command works differently to the point that it can't escape quotation marks properly, which makes the feedback system break. This should be investigated further, but this is good enough patch for now.

@Hans5958
Copy link
Member

Hans5958 commented Aug 23, 2024 •
edited
Loading

Problem is that v0.120 is been a while. The current version is v0.133 v0.134 v0.133. Something may change. I would test it, or you can test it too.

@Hans5958
Copy link
Member

Hans5958 commented Aug 23, 2024 •
edited
Loading

I checked using v0.134 v0.133 and it seems that they have fixed it. You can update it safely.

Hans5958
Hans5958 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@Hans5958 Hans5958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, I was confused between v0.133 and v0.134. I was correct on v0.133 last time!

By the way, thanks for the help!

@Hans5958 Hans5958 merged commit 3f4f253 into ScratchAddons:master Aug 23, 2024
4 checks passed
@Samq64 Samq64 deleted the fix-isserver branch August 23, 2024 02:48
@Samq64
Copy link
Member Author

Samq64 commented Aug 23, 2024

You're welcome and I'm a little confused too since the console message said 0.134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hans5958 Hans5958 Hans5958 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file type: bug Something isn't working (or is wrong in general)
Projects
Website
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samq64 @Hans5958