Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discuss-button page #484

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

Samq64
Copy link
Member

@Samq64 Samq64 commented Aug 20, 2024

Adds the customizable navigation bar addon to the docs.

@Samq64 Samq64 added type: enhancement New feature or request scope: docs Related to the documentation (Scratch Addons Docs) labels Aug 20, 2024
@Samq64 Samq64 marked this pull request as ready for review August 21, 2024 10:52
@Samq64
Copy link
Member Author

Samq64 commented Aug 21, 2024

What is the best way to add something to tne gallery? <figure>?

@Hans5958
Copy link
Member

What is the best way to add something to tne gallery? <figure>?

I just realised that I haven't thought about this yet.

Ideally it would be something like the gallery on Wikipedia, but I have to implement it. For now either ![]() and <img> would work. Only concern with <figure> is it may be harder for translators to translate, but I think it's fine if you want to try.

@Samq64

This comment was marked as outdated.

@Hans5958
Copy link
Member

I would merge this tommorow, unless you tell me that it wasn't ready, or I simply forgot.

@Hans5958 Hans5958 merged commit f101cf2 into ScratchAddons:master Aug 26, 2024
4 checks passed
@Samq64 Samq64 deleted the more-addon-pages branch August 28, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Related to the documentation (Scratch Addons Docs) type: enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants