Skip to content

Conversation

@llakenbr
Copy link

Description

Priorly toonify has encoded not implemented types as 'null', this PR adds support for Tuples and changes the behavior to raise an "NotImplementedError" for unknown types. The decoding of Tuples is handled them as a list and did not require additional implementations.

Related Issue

Not created

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

  • All tests pass
  • Added new tests for the changes
  • Tested manually with examples

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Documentation updated
  • No new warnings or errors introduced - Added a "NotImplementedError" for not implemented types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant