Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ollama: Fix install error #5920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StarsbySea
Copy link
Contributor

@StarsbySea StarsbySea commented Jun 17, 2024

Closes #5908
Closes #5909
Closes #5910
Closes #5911
Closes #5912
Closes #5913
Closes #5915
Closes #5917
Closes #5918

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ollama

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

1 similar comment
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ollama

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@StarsbySea
Copy link
Contributor Author

@niheaven Hi, Please take a look at this PR, thanks.

@0x00cl
Copy link

0x00cl commented Jun 17, 2024

I haven't tried this but is there any reason why the OllamaSetup.exe was failing?
I think its something that should be looked at before changing to downloading the .zip instead.

@infomaniac50
Copy link
Contributor

innounp.log says:

Signature detected: Inno Setup Setup Data (6.3.0)
This is not directly supported, but i'll try to unpack it as version 5602
; Version detected: 6300
Critical error: The setup files are corrupted. Please obtain a new copy of the program.

@infomaniac50
Copy link
Contributor

The OllamaSetup.exe installer works fine by itself. It drops the files in the users AppData folder as a non-admin install. The tray app and the server run fine.

Ollama v0.1.41 uses Inno Setup v6.1.0 where as Ollama v0.1.44 uses Inno Setup v6.3.0.

I assume the log is right and the new Inno Setup installer is not supported by innounp.

@infomaniac50
Copy link
Contributor

@0x00cl
Copy link

0x00cl commented Jun 18, 2024

Scoop uses innounp, latest version is 0.50 and supports upto Inno 6.1.2. which was last updated 2020.12.18 and latest Inno version is 6.3.1 (2024-06-10).

... But since it is not updated in a timely fashion, and so does not support the latest IS most of the time, this program was born.

A bit ironic :p

@0x00cl
Copy link

0x00cl commented Jun 21, 2024

Looks like innoextract could be an alternative? It already has a merge request to support 6.3.1 Inno Setup

"hash": "640c587550810b941e384618e4a0130e3cda56ac67f7894b821c141aefd6ad0c",
"innosetup": true,
"url": "https://github.com/ollama/ollama/releases/download/v0.1.44/ollama-windows-amd64.zip",
"hash": "483fef57f094f5a52d865182a0d6f9a2e8a59eb44dd756b4517ea9b747d90338",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase and update for version 0.1.47.

@kohded
Copy link

kohded commented Jul 1, 2024

Please don't replace the install of OllamaSetup.exe. This will remove "ollama app.exe" and isn't provided in the zip. The zip install could be called ollama-cli, or the OllamaSetup.exe install might be better suited in the extras bucket since "ollama app.exe" is a GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment