Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

television: Add version 0.9.2 #14706

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

television: Add version 0.9.2 #14706

wants to merge 22 commits into from

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Jan 9, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

fix #14741

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Your changes do not pass checks.

tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@Slach
Copy link
Contributor Author

Slach commented Jan 9, 2025

/verify

Copy link
Contributor

github-actions bot commented Jan 9, 2025

All changes look good.

Wait for review from human collaborators.

tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Contributor

@danielpauldd danielpauldd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested manifest. Works as expected.

@danielpauldd
Copy link
Contributor

@Slach there is no corresponding request issue for this PR. Please create one.

Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please update to the latest version.
  2. I suppose it would be more appropriate to rename manifest to television - same as original project.

bucket/tv.json Outdated Show resolved Hide resolved
bucket/tv.json Outdated Show resolved Hide resolved
Slach and others added 2 commits January 15, 2025 20:11
@Slach Slach changed the title [email protected]: add tv 0.9.1 [email protected]: add television 0.9.1 Jan 15, 2025
@Slach Slach changed the title [email protected]: add television 0.9.1 [email protected]: add television 0.9.2 Jan 15, 2025
@Slach
Copy link
Contributor Author

Slach commented Jan 15, 2025

@danielpauldd why CI/CD failed?

Error: [-] files end with a newline 67ms (66ms|1ms)

but, i already added it
look 3bba5e3

I don't understand how it possible
and why
https://github.com/Slach/scoop-extras-bucket/blame/add_tv/bucket/television.json
show only 24 lines
but contains 25 lines actually
image

why we need so stupid check? this is still valid JSON

@aliesbelik aliesbelik changed the title [email protected]: add television 0.9.2 television: Add version 0.9.2 Jan 16, 2025
@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

television

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: television fuzzy find
3 participants