Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubespy: Add version 0.6.3 #14361

Merged
merged 4 commits into from
Nov 13, 2024
Merged

kubespy: Add version 0.6.3 #14361

merged 4 commits into from
Nov 13, 2024

Conversation

cowwoc
Copy link
Contributor

@cowwoc cowwoc commented Nov 5, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

All changes look good.

Wait for review from human collaborators.

kubespy

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik added the package-request-needed Need package-request issue label Nov 6, 2024
@aliesbelik
Copy link
Collaborator

As a non-GUI tool could be submitted into the main bucket instead, since meeting the Main criteria.

@aliesbelik
Copy link
Collaborator

Please add arm64 version and hash autoupdate section as well.

@cowwoc
Copy link
Contributor Author

cowwoc commented Nov 6, 2024

@aliesbelik Thanks for the head's up regarding the main bucket. I didn't know it was an option.

Regarding the hash, does GitHub post sha256 values for all downloads? I couldn't find any reference for this...

aliesbelik
aliesbelik requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding arm64 version and hash autoupdate.

bucket/kubespy.json Show resolved Hide resolved
bucket/kubespy.json Show resolved Hide resolved
bucket/kubespy.json Show resolved Hide resolved
cowwoc and others added 3 commits November 7, 2024 08:35
@cowwoc @aliesbelik
Update bucket/kubespy.json
26b17f3 
Added ARM64 platform

Co-authored-by: Aliaksandr Belik <[email protected]>
@cowwoc @aliesbelik
Update bucket/kubespy.json
1577eaa 
Added binary hash

Co-authored-by: Aliaksandr Belik <[email protected]>
@cowwoc @aliesbelik
Update bucket/kubespy.json
2a10362 
Added ARM64 platform

Co-authored-by: Aliaksandr Belik <[email protected]>
@cowwoc
Copy link
Contributor Author

cowwoc commented Nov 7, 2024

Thank you!

@cowwoc
Copy link
Contributor Author

cowwoc commented Nov 7, 2024 •
edited
Loading

@aliesbelik Should I close this PR and open a new one against the main bucket? Or are we able to move it over somehow?

@aliesbelik aliesbelik changed the title Added kubespy kubespy: Add version 0.6.3 Nov 12, 2024
@aliesbelik
Copy link
Collaborator

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

kubespy

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik
Copy link
Collaborator

Should I close this PR and open a new one against the main bucket? Or are we able to move it over somehow?

I'm not maintainer of Main so I couldn't transfer your request.
If you feel enthusiastic enough, please re-create PR with final version of manifest in Main.
Otherwise looks good and could be merged into Extras.

@cowwoc
Copy link
Contributor Author

cowwoc commented Nov 12, 2024

Let's leave it in extra. You can go ahead with the merge. Thanks again for your help!

@aliesbelik aliesbelik merged commit 0a176ba into ScoopInstaller:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliesbelik aliesbelik aliesbelik approved these changes

Assignees
No one assigned
Labels
package-request-needed Need package-request issue review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cowwoc @aliesbelik