Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FUSE config and document it #8583

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

touilleMan
Copy link
Member

No description provided.

@touilleMan touilleMan requested a review from a team as a code owner October 2, 2024 09:21
@touilleMan touilleMan force-pushed the fuse-improved-config branch from b913e09 to 419e770 Compare October 2, 2024 09:22
.add_capabilities(fuser::consts::FUSE_READDIRPLUS_AUTO)
.expect("Capability available");

// TODO: `FUSE_SPLICE_READ` seems to require `write_buf()` to be implemented, which is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why read require write_buf, did you mean read_buf ?

Can you create an issue on fuser side ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop it's write_buf

Can you create an issue on fuser side ?

This is not related to fuser, it's documented as such on libfuse

I've created an issue on fuser side to try to better understand what is the support of write_buf on fuser: cberner/fuser#298

@touilleMan touilleMan force-pushed the fuse-improved-config branch 2 times, most recently from 490b655 to 4541d10 Compare October 2, 2024 10:46
@touilleMan touilleMan force-pushed the fuse-improved-config branch from 4541d10 to d2cf9c6 Compare October 3, 2024 14:38
@touilleMan touilleMan added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit ac65c3d Oct 4, 2024
14 checks passed
@touilleMan touilleMan deleted the fuse-improved-config branch October 4, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants