Skip to content

Use a generated SVG logo #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Use a generated SVG logo instead of the current one. Please tweak this however you like to get the logo you really want. And note that until this afternoon I had never used Tephi so if I've done something heinous please call me out on it!

Description

  • Avoids pixellation - infinitely scalable
  • Tephi logo generated via Tephi is kinda neat
  • Using a script means that changes will be more easily human-readable

Comment on lines -137 to -138
# docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32
# pixels large.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been true for years for most web browsers. The Iris Readthedocs page uses an SVG and that works just fine.

@trexfeathers
Copy link
Contributor Author

Gonna try to get it back down to the original size.

@trexfeathers trexfeathers marked this pull request as draft November 25, 2024 16:04
@trexfeathers
Copy link
Contributor Author

Gonna try to get it back down to the original size.

OK regardless of pixel size it seems to still render pretty big in RTD. There is probably some config we can put in conf.py but I've realised I should be leaving it to the reviewer to decide what they would prefer.

image

@trexfeathers trexfeathers marked this pull request as ready for review November 25, 2024 16:15
@ESadek-MO
Copy link
Contributor

I like the concept, feel like the code could be fiddled with:

  • Perhaps experiment with other fonts
  • Change the location of the plot lines, they coincidentally make a somewhat political symbol atm
  • Play with the colours a bit. The white on white is a little trippy

@trexfeathers
Copy link
Contributor Author

Text outlines are easy in Matplotlib apparently

image

Copy link

In order to maintain a backlog of relevant PRs, we automatically label them as stale after 168 days of inactivity.
If this PR is still important to you, then please comment on this PR and the stale label will be removed.
Otherwise this PR will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue or pull request label May 20, 2025
@ESadek-MO
Copy link
Contributor

I don't want this to go stale! I do want to fiddle with tephi generated logos at some point, it's just lower priority for the moment

@ESadek-MO ESadek-MO removed the Stale A stale issue or pull request label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants