Skip to content

Make MeshCoords immutable and sync updates with the attached mesh #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Apr 9, 2025

🚀 Pull Request

Description

Closes #4757, continues #6125.

This pull request aims to make MeshCoords immutable, and when it's corresponding Mesh updates, for the MeshCoord to refresh its Points, Bounds, and Metadata from the Mesh.

Notes to self
  • First problem, where node had no bounds, has been solved.
  • Next problem is that bounds aren't being rendered in the cml (and presumably, don't exist). There wasa thread to pull, in that bounds is set to an error message about bounds_dm, but it seems like that's a red herring, and is solved within __init__.
  • There's a chance this only solves another 10 or so errors, but progress is progress

@ESadek-MO ESadek-MO changed the title Make MeshCoords immutable and sync updates with it's mesh Make MeshCoords immutable and sync updates with the attached mesh Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: 🔖 Assigned
Development

Successfully merging this pull request may close these issues.

Ensure MeshCoord points and bounds always agree with the Mesh (while keeping Mesh mutable)
2 participants