Make MeshCoords immutable and sync updates with the attached mesh#6405
Make MeshCoords immutable and sync updates with the attached mesh#6405pp-mo merged 26 commits intoSciTools:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6405 +/- ##
==========================================
+ Coverage 89.88% 89.89% +0.01%
==========================================
Files 90 90
Lines 23945 24123 +178
Branches 4467 4489 +22
==========================================
+ Hits 21522 21685 +163
- Misses 1670 1679 +9
- Partials 753 759 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stephenworsley
left a comment
There was a problem hiding this comment.
Looking good! Here's some comments from the code itself, I'll go through the tests next. The timestamp stuff looks like it should do the job now, I think mostly I just have virable name and documentation quibbles.
stephenworsley
left a comment
There was a problem hiding this comment.
Looking good, I believe these are the last things I can find to request changes on, after this it should be good to merge!
|
Thanks @ESadek-MO @stephenworsley |
🚀 Pull Request
Description
Closes #4757, continues #6125.
This pull request aims to make MeshCoords immutable, and when it's corresponding Mesh updates, for the MeshCoord to refresh its Points, Bounds, and Metadata from the Mesh.
Notes to self
nodehad no bounds, has been solved.boundsis set to an error message aboutbounds_dm, but it seems like that's a red herring, and is solved within__init__.