Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use approximate sparsity detection by default #318

Closed
wants to merge 1 commit into from

Conversation

avik-pal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

If Symbolics.jl is not loaded, it uses ForwardDiff for approximate sparsity detection. I am displaying a warning because this can lead to failures due to incorrect sparsity pattern. But overall this is very promising at least for the brusselator example. Approximate Detection + Solving takes the similar time as Symbolics Solving (symbolic detection being extremely slow)

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7ef4af) 80.48% compared to head (893d084) 89.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   80.48%   89.37%   +8.89%     
==========================================
  Files          23       24       +1     
  Lines        1942     1949       +7     
==========================================
+ Hits         1563     1742     +179     
+ Misses        379      207     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant