fix: handle invalid oidc session date after jwt is expired #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/frontend into datasets-filter-conditions
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @abdimo101 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -179,6 +220,229 @@ export class DatasetsFilterComponent implements OnInit, OnDestroy { | |||
| this.store.dispatch(fetchFacetCountsAction()); | |||
| } | |||
|
|
|||
| trackByCondition(index: number, conditionConfig: ConditionConfig): string { | |||
| const condition = conditionConfig.condition; | |||
There was a problem hiding this comment.
suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)
Suggested change
| const condition = conditionConfig.condition; | |
| const {condition} = conditionConfig; |
Explanation
Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.From the Airbnb Javascript Style Guide
| this.asyncPipe.transform(this.conditionConfigs$) || []; | ||
| const updatedConditions = [...currentConditions]; | ||
| updatedConditions[index] = { ...updatedConditions[index], enabled }; | ||
| const condition = updatedConditions[index].condition; |
There was a problem hiding this comment.
suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)
Suggested change
| const condition = updatedConditions[index].condition; | |
| const {condition} = updatedConditions[index]; |
Explanation
Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.From the Airbnb Javascript Style Guide
| @@ -39,7 +39,8 @@ export class AuthService { | |||
| this.token.id = this.load("id"); | |||
| this.token.user = JSON.parse(this.load("user") || null); | |||
| this.token.userId = this.load("userId"); | |||
| this.token.created = new Date(this.load("created")); | |||
| const date = new Date(this.load("created")); | |||
| this.token.created = !isNaN(date.getTime()) ? date : null; | |||
There was a problem hiding this comment.
suggestion (code-quality): Invert ternary operator to remove negation (invert-ternary)
Suggested change
| this.token.created = !isNaN(date.getTime()) ? date : null; | |
| this.token.created = isNaN(date.getTime()) ? null : date; |
Explanation
Negated conditions are more difficult to read than positive ones, so it is bestto avoid them where we can. By inverting the ternary condition and swapping the
expressions we can simplify the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix authentication issues and infinite loading after logging in with OIDC and returning with an expired JWT.
Motivation
When logging in with OIDC and returning to the site after the JWT expires, the site would attempt to fetch user data and dataset table get stuck in an infinite loading state. This happened because the invalid
createdproperty in OIDC session caused theisTokenExpiredcheck to fail.Fixes:
createdproperty to prevent unnecessary API calls and ensures authentication cookies are cleared when the JWT has expired.Changes:
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Handle invalid OIDC session dates to fix authentication loops after expired JWTs and overhaul the dataset filter component to introduce a full-featured scientific conditions UI with corresponding test coverage
Bug Fixes:
Enhancements:
Build:
Tests: