Skip to content

refactor: remove localLoginLabel #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: remove localLoginLabel #1905

wants to merge 3 commits into from

Conversation

GBirkel
Copy link
Contributor

@GBirkel GBirkel commented Jun 23, 2025 •
edited
Loading

Description

Just some minor housekeeping. Removing deprecated key "localLoginLabel" from default config file.

Addresses SciCatProject/scicat-backend-next#1952 .

Summary by Sourcery

CI:

  • Remove deprecated "localLoginLabel" from CI E2E frontend config

sourcery-ai[bot]
sourcery-ai bot reviewed Jun 23, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GBirkel - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Junjiequan Junjiequan Junjiequan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GBirkel @Junjiequan