Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: new sdk release #1658

Merged
merged 66 commits into from
Dec 4, 2024
Merged

BREAKING CHANGE: new sdk release #1658

merged 66 commits into from
Dec 4, 2024

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Nov 13, 2024

Description

This PR implements the refactoring needed to migrate the FE from the old SDK to the new autogenerated one.

Motivation

SciCat BE has typescipt SDK autogenerated at each release, the FE should use the new SDK which allows to access the new BE functionalities.

Fixes:

Please provide a list of the fixes implemented in this PR

  • TBD

Changes:

Please provide a list of the changes implemented by this PR

  • TBD

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

martin-trajanovski and others added 30 commits October 29, 2024 14:42
…d-code-refactor

feat: add the new auth service to prepare for the new sdk
…d-code-refactor-part-2

fix: adjust types after using the new sdk
…d-code-refactor-part-3

feat: add new sdk generation script for local development
…ontend into SWAP-4278-new-sdk-frotnend-code-refactor-part-4
adapted sdk generation to unix environment
…d-code-refactor-part-4

refactor: new sdk frontend code refactor part 4
@martin-trajanovski martin-trajanovski changed the title New sdk release feat: new sdk release Nov 28, 2024
Copy link
Contributor

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would suggest issuing a major (or at least minor) tag once this is merged

Copy link
Contributor Author

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes requested

@martin-trajanovski
Copy link
Collaborator

LGTM. I would suggest issuing a major (or at least minor) tag once this is merged

Yes I agree. Maybe major release should be issued after this gets in.

@martin-trajanovski martin-trajanovski changed the title feat: new sdk release BREAKING CHANGE: new sdk release Dec 4, 2024
@martin-trajanovski martin-trajanovski merged commit ab8a166 into master Dec 4, 2024
6 checks passed
@martin-trajanovski martin-trajanovski deleted the new-sdk-release branch December 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants