Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate webix datatable #1505

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Integrate webix datatable #1505

wants to merge 1 commit into from

Conversation

Ingvord
Copy link
Contributor

@Ingvord Ingvord commented Jun 14, 2024

Proof of the concept

Peek 2024-06-15 01-57

Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

this.webixUi.refreshColumns();
}

getWebixColumns(): any[] {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method shows various possible (not all though) column configuration options. See Configuring Columns for more details

}

initializeWebixTable(): void {
this.webixUi = webix.ui({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webix Datatable creation and configuration

@sbliven
Copy link
Contributor

sbliven commented Jun 17, 2024

Looks intriguing. Could the column filters replace the "Filter by..." sidebar?

How is the performance? Do the sort and filter use the same indexes as in the previous implementation?

@Ingvord
Copy link
Contributor Author

Ingvord commented Jun 17, 2024 via email

@nitrosx
Copy link
Contributor

nitrosx commented Jun 24, 2024

Thanks for the proof-of-concept.
I'm hesitant to include another full fledged toolkit in the FE just to add the table feature.
I worry that we are going to complicate more the code and make it even more difficult to manage and maintain.

@Ingvord
Copy link
Contributor Author

Ingvord commented Jun 24, 2024 via email

@sbliven
Copy link
Contributor

sbliven commented Jun 25, 2024

We talked about this PR in the meeting today. A couple concerns came up.

  1. Pricing Are all the features we would need available in webix standard (the GPL version)? IMO webix pro licenses are out of the question.
  2. Client-side filtering. I think users would be very confused that filters are done client side and apply only to the current page of results. I think it needs to be done server-side like the facets, or else it should be omitted from the table.
  3. Maintenance. It seems like adding webix would increase the complexity of the frontend significantly, and could increase the maintenance burden. I get that this is just a proof of concept, but while the sorting and resizing features shown here would be nice they would hardly be worth it if they make the frontend harder to maintain and develop. Do you see some "killer features" that would have a high impact on the user experience that would come with webix but not available with the current framework?

@Ingvord
Copy link
Contributor Author

Ingvord commented Jul 6, 2024

Following the discussions at SciCatCon 2024 I will repurpose this PR to demonstrate how to plugins in SciCat FE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants