Configurable facets #1465
Configurable facets #1465
Conversation
Ingvord
commented
Apr 27, 2024
•
Ingvord
commented
- Proof of the concept
- Refactor dataset-filters.component: extract individual filters
- Fix tests
- Add FilterSettingsDialog test
- Make custom filter UX consistent with dialog
- Replace PID condition configuration with two runtime PID filters #1466
- store configuration in the local storage
* First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting
Explicit search button
* Change label * Add button * Add button * Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Fix layout * Add functionality to the button
Ingvord
added
discussion
Release Search UI
meeting
|
Apparently there are some changes picked up from the master which make the overall UI/UX much more consistent., thanks to @Junjiequan . I took the liberty to do minor adjustments though:
Please note the icons and labels:
|
|
@Ingvord it looks good!!! One more thing: I checked and the three horizontal lines slightly tilted are indeed the official icon for clear all. |
|
@nitrosx Thanks for your "in no time" comment :) Regarding the icons I refer to this resource: https://fonts.google.com/icons
My intention is to make them consistent in a way that they both do clear and apply. My motivation - they are located in a "major action" section area and have the same look-n-feel as apply/search, so I would expect them to perform something more than just clear. Ah and we lost "x" from full text, which should do only clear... However the functionality requires more love for sure 🤠 |
|
All green 🍾 🥂 |
| super(); | ||
| this.subscription = this.pidSubject | ||
| .pipe( | ||
| skipWhile((terms) => terms.length < 5), |
There was a problem hiding this comment.
I really think this is redundant now. As we force user to explicitly click the action button, this just introduces a lot of confusion.
|
