chore: update with repo template #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated with open-source-polarion-python-repo-template and added tests for 90% coverage
move test script
Change test script permissions
update sonar properties
Try different regex
Fix regex
Fix regex
Fix sonar issue
Fix sonar issue
remove manual sonar in ci.yml
Add test comments and fix float values in get_px_conversion_ratio
|
ariwk
requested changes
Feb 11, 2025
| @@ -1,10 +1,19 @@ | |||
| FROM python:3.13.1-slim@sha256:f41a75c9cee9391c09e0139f7b49d4b1fbb119944ec740ecce4040626dc07bed | |||
| # hadolint global ignore=DL3008 | |||
| to_base64, | ||
| ) | ||
|
|
||
| test_script_path = "./tests/test.sh" |
There was a problem hiding this comment.
why shell call instead of python code?
|
|
||
| from app.weasyprint_controller import app | ||
|
|
||
| test_script_path = "./tests/test.sh" |
There was a problem hiding this comment.
why shell code instead of python?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use the open-source-polarion-docker-repo-template as a base for python docker repo and update config and github files.
Add tests and typing to pass checks
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument