Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(workbench): fix documentation of part Getting Started #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(workbench): fix documentation of part Getting Started #604

wants to merge 1 commit into from

Conversation

simoneggler
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, removal of deprecations, etc)
  • Deps (changes related to updating dependencies)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

danielwiehl
danielwiehl requested changes Oct 2, 2024
View reviewed changes
docs/site/getting-started.md
@@ -60,6 +60,31 @@ Open `app.config.ts` and register SCION Workbench providers. Added lines are mar
```
</details>

<details>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it to the next section (Insert SCION Workbench Component) so we have modifications to all files (html, ts, scss) in a single section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the how-to-install-workbench.md file accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwiehl danielwiehl danielwiehl requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoneggler @danielwiehl